Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Conversation

@Christellah
Copy link
Contributor

@Christellah Christellah commented Aug 21, 2019

Description:

We now only allows the user to use the serial monitor if they have a folder open, because the file cpx.json can only be created in a workspace. This way we let the user use the extension without a folder but they'll receive an error if they try to use a serial monitor related command.
(Fixing BUG:32887)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Limitations:

In the future, it would be interesting to let the user use the serial monitor even if they don't have a folder opened or just a file opened.

Testing:

  • Try running serial monitor commands with no folder opened (with a file and without a file opened) : it should prompt you a popup
  • Try running serial monitor command with a folder open and make sure it's still working properly

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@jonathanwangg jonathanwangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it out and works as described. Code looks great as well!

@Christellah Christellah merged commit de08372 into dev Aug 22, 2019
@jonathanwangg jonathanwangg deleted the users/t-chcido/fix-activation-no-folder branch August 26, 2019 09:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants