Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Persist user's choice for "Don't Show Again" for "New File" command #142

Merged
jonathanwangg merged 2 commits into from
Aug 23, 2019
Merged

Persist user's choice for "Don't Show Again" for "New File" command #142

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f80b52a
Persist user's choice for Don't Show Again for New File command
jonathanwangg Aug 23, 2019
8e5963b
Use a better name for variable
jonathanwangg Aug 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ let inDebugMode: boolean = false;
let debuggerCommunicationHandler: DebuggerCommunicationServer;
// Notification booleans
let firstTimeClosed: boolean = true;
let shouldShowNewFile: boolean = true;
let shouldShowInvalidFileNamePopup: boolean = true;
let shouldShowRunCodePopup: boolean = true;
export let outChannel: vscode.OutputChannel | undefined;
Expand Down Expand Up @@ -238,8 +237,9 @@ export async function activate(context: vscode.ExtensionContext) {
const fileName = "template.py";
const filePath = __dirname + path.sep + fileName;
const file = fs.readFileSync(filePath, "utf8");
const shouldShowNewFilePopup: boolean = context.globalState.get("shouldShowNewFilePopup", true);

if (shouldShowNewFile) {
if (shouldShowNewFilePopup) {
vscode.window
.showInformationMessage(
CONSTANTS.INFO.NEW_FILE,
Expand All @@ -249,7 +249,7 @@ export async function activate(context: vscode.ExtensionContext) {
)
.then((selection: vscode.MessageItem | undefined) => {
if (selection === DialogResponses.DONT_SHOW) {
shouldShowNewFile = false;
context.globalState.update("shouldShowNewFilePopup", false);
telemetryAI.trackFeatureUsage(
TelemetryEventName.CLICK_DIALOG_DONT_SHOW
);
Expand Down