Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Conversation

@jonathanwangg
Copy link
Contributor

Description:

Change the Don't Show Again from a globalState to a Setting that is persisted and can be changed easily.

Type of change

  • New feature (non-breaking change which adds functionality)

Limitations:

None

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Run the "New File" Command, click "Don't Show Again", Run the "New File" command and make sure you don't see the pop up anymore.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@jonathanwangg jonathanwangg merged commit 21a234c into dev Aug 23, 2019
@jonathanwangg jonathanwangg deleted the users/t-jowang/dont-show-setting branch August 26, 2019 09:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants