Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Conversation

@LukeSlev
Copy link
Member

@LukeSlev LukeSlev commented Sep 8, 2019

Description:

This PR makes the shake button actually shake the CPX. Crazy, right?
shake

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Testing:

  • make sure the shake button shakes the cpx

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@LukeSlev LukeSlev changed the title make the cpx shake Make the cpx shake Sep 8, 2019
@msftclas
Copy link

msftclas commented Sep 8, 2019

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@xnkevinnguyen xnkevinnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No breaking changes and works well :). It is updated with latest dev.

@xnkevinnguyen xnkevinnguyen merged commit 61d8149 into dev Jan 28, 2020
@xnkevinnguyen xnkevinnguyen deleted the users/t-luslev/shake-the-cpx branch February 3, 2020 22:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants