This repository was archived by the owner on Dec 23, 2021. It is now read-only.
Refactor toolbar and actionbar #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xnkevinnguyen
requested review from
LukeSlev,
abmahdy,
adclements,
iennae,
markAtMicrosoft and
smmatte
as code owners
xnkevinnguyen
changed the title
andreamah
approved these changes
Jan 22, 2020
Contributor
andreamah
left a comment
andreamah
left a comment
There was a problem hiding this comment.
Good! Thanks for the organized refactoring 👍
vandyliu
reviewed
Jan 22, 2020
src/view/components/Simulator.tsx
Outdated
| import Dropdown from "./Dropdown"; | ||
| import ActionBar from "./simulator/ActionBar" | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
nit: one line between these imports? or is this a convention for css files?
vandyliu
reviewed
Jan 22, 2020
| if (l > 50) s = 100 * (cDelta / (2 - maxAndMin)); | ||
| else s = 100 * (cDelta / maxAndMin); | ||
| if (l > 50) { s = 100 * (cDelta / (2 - maxAndMin)); } | ||
| else { s = 100 * (cDelta / maxAndMin); } |
Contributor
There was a problem hiding this comment.
nit: would look better if it were like:
if () {
...
} else {
...
}
or as ternary operator
vandyliu
reviewed
Jan 22, 2020
| border-color: var(--vscode-highContrastButtonBorderOverride-color); | ||
| border-width: 1px; | ||
| border-style: solid; | ||
| } |
Contributor
There was a problem hiding this comment.
nit: add space in between here
vandyliu
reviewed
Jan 22, 2020
src/view/container/device/Device.tsx
Outdated
| image: TOOLBAR_SVG.LIGHT_SVG, | ||
| label: TOOLBAR_ICON_ID.LIGHT, | ||
| } | ||
| , { |
Contributor
There was a problem hiding this comment.
nit: these brackets are all messed up and inconsistent
Contributor
Author
There was a problem hiding this comment.
thanks for the heads up. I'll actually make it a task to have proper linting rules and set up so it doesnt slow us down in the future
markAtMicrosoft
approved these changes
Jan 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In preparation of expanding functionality of the extension, making component reusable is a priority to reduce technical debt in the near future.
Refactoring of component by extracting 2 components:
Also contains:
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please delete options that are not relevant.
Limitations:
Please describe limitations of this PR
Testing:
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: