Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Conversation

@andreamah
Copy link
Contributor

Description:

Allowed for both imports as:
from adafruit_circuitplayground import cp
and
from adafruit_circuitplayground.express import cpx

This was requested since the first import statement above is how most tutorials present the import statement.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Limitations:

Testing:

  • Test with simulation and deploy to board

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@andreamah
Copy link
Contributor Author

It seems that CircuitPython's standard import statement changed a few months ago. It now can automatically detect the CP board type (Bluefruit vs Express). See: adafruit/Adafruit_CircuitPython_CircuitPlayground@cfa0053#diff-83e362785431178a0efc45ce23e99323

@andreamah andreamah requested review from jonathanwangg, vandyliu and xnkevinnguyen and removed request for jonathanwangg January 22, 2020 00:18
@vandyliu
Copy link
Contributor

Nice fix and nice find!

@vandyliu vandyliu closed this Jan 22, 2020
@vandyliu vandyliu reopened this Jan 22, 2020
Copy link
Contributor

@isadorasophia isadorasophia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was simple enough 😮 Cool!

@andreamah andreamah merged commit 0c56aca into dev Jan 22, 2020
@vandyliu vandyliu deleted the users/t-anmah/cpx-library-name-change branch January 23, 2020 03:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants