This repository was archived by the owner on Dec 23, 2021. It is now read-only.
Using a formatter and editing linting/formatting rules#176
Merged
xnkevinnguyen merged 5 commits intodevfrom Jan 24, 2020
Merged
Using a formatter and editing linting/formatting rules#176xnkevinnguyen merged 5 commits intodevfrom
xnkevinnguyen merged 5 commits intodevfrom
Conversation
isadorasophia
approved these changes
Jan 23, 2020
Contributor
isadorasophia
left a comment
There was a problem hiding this comment.
Cool! I would just suggest adding the commands for formatting in the documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Using a formatter to make our code look more clean: prettier for typescript and black for python. The code stylings were quite inconsistent and there were many linting errors (and still are), but hopefully using formatters can help us with our code quality. Also, the formatting checks will be added to CI if this is merged. All the src code files that are changed were changed by the formatters.
New commands:
npm run lintnpm run checknpm run formatType of change
Please delete options that are not relevant.
Testing:
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: