Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Conversation

@vandyliu
Copy link
Contributor

Description:

  • Add prettier to package.json, so it can run in the CI properly
  • Added dependency license.
  • Formatted a file with prettier that wasn't previously formatted

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@xnkevinnguyen xnkevinnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for adding the third party notices

@vandyliu vandyliu merged commit ce5a509 into dev Jan 27, 2020
@vandyliu vandyliu deleted the users/t-vali/add-prettier-to-package-json branch January 27, 2020 21:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants