Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Conversation

@andreamah
Copy link
Contributor

Description:

Update: I took another look at the pylint import error and I think I was able to get init-hook to recognize the libraries that are local to the extention!! Originally, I couldn't figure it out and closed the original PR.

Original Issue: All references to the local libraries (like adafruit_circuitplayground) were flagged as missing imports by pylint.

Type of change

  • [ x ] Bug fix (non-breaking change which fixes an issue)

Limitations:

Testing:

  • Test with importing local libraries + checks with non-installed libraries to see if import errors still come up

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@isadorasophia isadorasophia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay :D

Copy link
Contributor

@vandyliu vandyliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run prettier & should be good 💃

@andreamah andreamah merged commit 67d532f into dev Jan 28, 2020
@andreamah andreamah deleted the users/t-anmah/pylint-import-error-fix branch January 28, 2020 01:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants