This repository was archived by the owner on Dec 23, 2021. It is now read-only.
Creating the skeleton of the microbit library and adding a button object #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vandyliu
requested review from
abmahdy,
adclements,
iennae,
isadorasophia,
markAtMicrosoft,
nasadigital and
sagarmanchanda
as code owners
vandyliu
requested review from
DanielMeixner,
andreamah and
xnkevinnguyen
and removed request for
DanielMeixner
nasadigital
reviewed
Jan 31, 2020
nasadigital
left a comment
nasadigital
left a comment
There was a problem hiding this comment.
I am impressed how thorough the tests are! Great job.
added 2 commits
January 31, 2020 09:25
nasadigital
reviewed
Jan 31, 2020
nasadigital
left a comment
nasadigital
left a comment
There was a problem hiding this comment.
Thanks for addressing the comments!
nasadigital
reviewed
Jan 31, 2020
sagarmanchanda
approved these changes
Jan 31, 2020
xnkevinnguyen
pushed a commit
that referenced
this pull request
Feb 3, 2020
…ect (#185) * Created skeleton of microbit library * Added button model to microbit model Co-authored-by: Andrea Mah <31675041+andreamah@users.noreply.github.com>
xnkevinnguyen
added a commit
that referenced
this pull request
Feb 3, 2020
…ect (#185) * Created skeleton of microbit library * Added button model to microbit model Co-authored-by: Andrea Mah <31675041+andreamah@users.noreply.github.com> Remove outdated tests Update Snapshot Remove tslint comment Remove comment
xnkevinnguyen
added a commit
that referenced
this pull request
Feb 4, 2020
…ect (#185) * Created skeleton of microbit library * Added button model to microbit model Co-authored-by: Andrea Mah <31675041+andreamah@users.noreply.github.com> Remove outdated tests Update Snapshot Remove tslint comment Remove comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding the skeleton/structure of the microbit library. This was based off Andrea's closed PR, which Sagar commented on. Also included the basic button class in it.
Type of change
Limitations:
Please describe limitations of this PR
Testing:
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
npm run formatand passes the checks innpm run check