This repository was archived by the owner on Dec 23, 2021. It is now read-only.
Hotfix for users without Git #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreamah
requested review from
abmahdy,
adclements,
iennae,
isadorasophia,
markAtMicrosoft,
nasadigital,
sagarmanchanda and
smmatte
as code owners
|
@andreamah How can I build a .vsix to try if it fixes the issue? |
Contributor
Author
I'll create a vsix and send it to you. |
Contributor
|
This definitely sounds okay for a hot fix! Were you able to get repro it or get to the bottom of the underlying issue though? Was it something with a git requirement? |
Contributor
Author
The underlying issue was that users needed Git. Pip installing from a tar.gz file requires Git for some reason |
andreamah
force-pushed
the
users/t-anmah/tarball-bug-fix
branch
from
37032b2 to
9a0c839
Compare
vandyliu
approved these changes
Apr 16, 2020
Contributor
vandyliu
left a comment
vandyliu
left a comment
There was a problem hiding this comment.
Tested on windows computer without git!
xnkevinnguyen
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The tarball for adafruit_display_text was having trouble being unzipped for users without git. I moved the tarball files to the
src/cluedirectory so that it doesn't need to be unzipped + installed via pip.label.py was originally within the zipped tarball, but now it is in src/clue/adafruit_display_text/label.py
Type of change
Please delete options that are not relevant.
Testing:
Tested on windows on code that uses adafruit_clue and adafruit_display_text.