Conversation
| ] | ||
| self.__state[CONSTANTS.EXPRESS_STATE.RED_LED] = False | ||
| self.__state[CONSTANTS.EXPRESS_STATE.SWITCH] = False | ||
| self.__state[CONSTANTS.EXPRESS_STATE.SWITCH] = True |
There was a problem hiding this comment.
I would expect the switch to be turned off by default, would you agree?
There was a problem hiding this comment.
You're right. After looking at the pictures, it seems that default is off.
|
Just a comment, the switch is red when turned off and grey when turned on. That's fine with me, since previously it used to be red when turned on but you might want to think about it. |
Yea, we wanted to inverse it since users were expecting the opposite. Maybe Green would be a better choice then gray for ON. But will be thought of in the future |
Description:
After revision of the doc, the True state of the switch should be at the left and False at the right. See https://learn.adafruit.com/circuitpython-made-easy-on-circuit-playground-express/slide-switch.
Reported here: #344
Repro steps:
1.Run this code
Current behaviour: The led will turn ON if the switch is on the right
Expected behaviour: The led will turn ON if the swith is on the left.
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please delete options that are not relevant.
Limitations:
Please describe limitations of this PR
Testing:
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
npm run formatand passes the checks innpm run check