Allow package manager to fully control install/uninstall steps#105
Merged
karthiknadig merged 5 commits intomicrosoft:mainfrom Jan 9, 2025
Merged
Allow package manager to fully control install/uninstall steps#105karthiknadig merged 5 commits intomicrosoft:mainfrom
karthiknadig merged 5 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 8 out of 17 changed files in this pull request and generated 2 comments.
Files not reviewed (9)
- .vscode/settings.json: Language not supported
- examples/sample1/src/api.ts: Evaluated as low risk
- src/internal.api.ts: Evaluated as low risk
- src/common/localize.ts: Evaluated as low risk
- src/common/pickers/packages.ts: Evaluated as low risk
- src/api.ts: Evaluated as low risk
- src/managers/builtin/venvUtils.ts: Evaluated as low risk
- src/features/envCommands.ts: Evaluated as low risk
- src/managers/conda/condaPackageManager.ts: Evaluated as low risk
Comments suppressed due to low confidence (5)
src/managers/common/pickers.ts:21
- [nitpick] The
Installableinterface has bothnameanddisplayNameproperties, which might be confusing. Consider renamingnameto something more specific, likeid.
export interface Installable {
src/managers/builtin/pipManager.ts:52
- Ensure that the new behavior of prompting the user to select packages when none are provided is covered by tests.
async install(environment: PythonEnvironment, packages?: string[], options?: PackageInstallOptions): Promise<void> {
src/managers/builtin/pipManager.ts:91
- Ensure that the new behavior of prompting the user to select packages when none are provided is covered by tests.
async uninstall(environment: PythonEnvironment, packages?: Package[] | string[]): Promise<void> {
src/managers/conda/condaUtils.ts:26
- The
runCondafunction should handle errors when parsing JSON and provide a clear error message if parsing fails.
return JSON.parse(raw);
src/managers/conda/condaUtils.ts:694
- [nitpick] Ensure that the
descriptionfield is consistently used across the codebase and correctly populated in theselectFromCommonPackagesToInstallfunction.
description: p.description,
Member
Author
|
@jjjermiah This should allow you to fully control the install/uninstall experience. I have removed the installable API. Instead, I directly call into the |
eleanorjboyd
approved these changes
Jan 9, 2025
NguyenCuong1989
referenced
this pull request
in NguyenCuong1989/vscode-python-environments
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #99