Handle activation disposes correctly

[karthiknadig]

Fixes #127

[Copilot]

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/features/terminal/terminalManager.ts:162

• [nitpick] The error message for the shell execution timeout is not very informative. Consider providing more context about the impact of the timeout.

traceError(`Shell execution timed out: ${command.executable} ${command.args?.join(' ')}`);

src/features/terminal/terminalManager.ts:160

• Ensure that the new timeout behavior is covered by tests.

let timer: NodeJS.Timeout | undefined = setTimeout(() => {

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

[Copilot]

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/features/terminal/terminalManager.ts:162

• [nitpick] The error message for the shell execution timeout could be more descriptive. Consider including additional context or suggestions for troubleshooting.

traceError(`Shell execution timed out: ${command.executable} ${command.args?.join(' ')}`);

src/features/terminal/terminalManager.ts:385

• The new function isTaskTerminal should have test coverage to ensure it behaves as expected.

return terminal.name.toLowerCase().includes('task');

Tip: Turn on automatic Copilot reviews for this repository to get quick feedback on every pull request. Learn more

[vs-code-engineering]

⚠️ This PR originates from a fork. Due to security restrictions, pipelines from forks are no longer triggered automatically. Learn more.

If the changes appear safe, you can manually trigger the pipeline by commenting /AzurePipelines run.