fix: remove intrusive error notification for unresolvable Python paths (Fixes #1283)

src/common/pickers/environments.ts

@@ -1,4 +1,4 @@
-import { ProgressLocation, QuickInputButtons, QuickPickItem, QuickPickItemKind, ThemeIcon, Uri } from 'vscode';
+import { ProgressLocation, QuickInputButtons, QuickPickItem, QuickPickItemKind, ThemeIcon, Uri, l10n } from 'vscode';
 import { CreateEnvironmentOptions, IconPath, PythonEnvironment, PythonProject } from '../../api';
 import { InternalEnvironmentManager } from '../../internal.api';
 import { Common, Interpreter, Pickers } from '../localize';
@@ -7,7 +7,13 @@ import { EventNames } from '../telemetry/constants';
 import { sendTelemetryEvent } from '../telemetry/sender';
 import { isWindows } from '../utils/platformUtils';
 import { handlePythonPath } from '../utils/pythonPath';
-import { showOpenDialog, showQuickPick, showQuickPickWithButtons, withProgress } from '../window.apis';
+import {
+    showErrorMessage,
+    showOpenDialog,
+    showQuickPick,
+    showQuickPickWithButtons,
+    withProgress,
+} from '../window.apis';
 import { pickEnvironmentManager } from './managers';
 
 type QuickPickIcon =
@@ -66,6 +72,11 @@ async function browseForPython(
             return env;
         },
     );
+
+    if (!environment) {
+        showErrorMessage(l10n.t('Selected file is not a valid Python interpreter: {0}', uri.fsPath));
+    }
+
     return environment;
 }
 

src/common/utils/pythonPath.ts

@@ -1,9 +1,8 @@
-import { Uri, Progress, CancellationToken } from 'vscode';
+import { CancellationToken, Progress, Uri } from 'vscode';
 import { PythonEnvironment } from '../../api';
 import { InternalEnvironmentManager } from '../../internal.api';
-import { traceVerbose, traceError } from '../logging';
 import { PYTHON_EXTENSION_ID } from '../constants';
-import { showErrorMessage } from '../window.apis';
+import { traceVerbose, traceWarn } from '../logging';
 
 const priorityOrder = [
     `${PYTHON_EXTENSION_ID}:pyenv`,
@@ -74,7 +73,6 @@ export async function handlePythonPath(
         }
     }
 
-    traceError(`Unable to handle ${interpreterUri.fsPath}`);
-    showErrorMessage(`Unable to handle ${interpreterUri.fsPath}`);
+    traceWarn(`Unable to handle ${interpreterUri.fsPath}`);
     return undefined;
 }

src/features/envCommands.ts

@@ -1,6 +1,15 @@
 import * as fs from 'fs-extra';
 import * as path from 'path';
-import { ProgressLocation, QuickInputButtons, TaskExecution, TaskRevealKind, Terminal, Uri, workspace } from 'vscode';
+import {
+    ProgressLocation,
+    QuickInputButtons,
+    TaskExecution,
+    TaskRevealKind,
+    Terminal,
+    Uri,
+    l10n,
+    workspace,
+} from 'vscode';
 import {
     CreateEnvironmentOptions,
     PythonEnvironment,
@@ -93,6 +102,10 @@ async function browseAndResolveInterpreter(
         },
     );
 
+    if (!environment) {
+        showErrorMessage(l10n.t('Selected file is not a valid Python interpreter: {0}', interpreterUri.fsPath));
+    }
+
     return environment;
 }
 

src/test/common/pythonPath.unit.test.ts

@@ -0,0 +1,171 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+import assert from 'node:assert';
+import * as sinon from 'sinon';
+import { CancellationTokenSource, Uri } from 'vscode';
+import { PythonEnvironment } from '../../api';
+import { handlePythonPath } from '../../common/utils/pythonPath';
+import { InternalEnvironmentManager } from '../../internal.api';
+
+function createMockManager(
+    id: string,
+    displayName: string,
+    resolveResult: PythonEnvironment | undefined = undefined,
+): sinon.SinonStubbedInstance<InternalEnvironmentManager> {
+    return {
+        id,
+        displayName,
+        resolve: sinon.stub().resolves(resolveResult),
+    } as unknown as sinon.SinonStubbedInstance<InternalEnvironmentManager>;
+}
+
+function createMockEnv(managerId: string): PythonEnvironment {
+    return {
+        envId: { id: `env-${managerId}`, managerId },
+        name: `env-${managerId}`,
+        displayName: `Env ${managerId}`,
+        version: '3.11.0',
+        displayPath: '/usr/bin/python3',
+        environmentPath: Uri.file('/usr/bin/python3'),
+        sysPrefix: '/usr',
+        execInfo: { run: { executable: '/usr/bin/python3' } },
+    } as PythonEnvironment;
+}
+
+suite('handlePythonPath', () => {
+    const testUri = Uri.file('/test/python3');
+
+    teardown(() => {
+        sinon.restore();
+    });
+
+    test('returns undefined when no managers can resolve the path', async () => {
+        const manager1 = createMockManager('ms-python.python:venv', 'Venv');
+        const manager2 = createMockManager('ms-python.python:conda', 'Conda');
+
+        const result = await handlePythonPath(testUri, [manager1, manager2], []);
+
+        assert.strictEqual(result, undefined);
+    });
+
+    test('returns environment from project manager that resolves first', async () => {
+        const mockEnv = createMockEnv('ms-python.python:venv');
+        const projectManager = createMockManager('ms-python.python:venv', 'Venv', mockEnv);
+        const globalManager = createMockManager('ms-python.python:conda', 'Conda');
+
+        const result = await handlePythonPath(testUri, [globalManager], [projectManager]);
+
+        assert.strictEqual(result, mockEnv);
+        // Global manager should NOT have been called since project manager resolved
+        assert.strictEqual((globalManager.resolve as sinon.SinonStub).called, false);
+    });
+
+    test('falls back to global managers when project managers cannot resolve', async () => {
+        const mockEnv = createMockEnv('ms-python.python:conda');
+        const projectManager = createMockManager('ms-python.python:venv', 'Venv');
+        const globalManager = createMockManager('ms-python.python:conda', 'Conda', mockEnv);
+
+        const result = await handlePythonPath(testUri, [globalManager], [projectManager]);
+
+        assert.strictEqual(result, mockEnv);
+    });
+
+    test('does not re-check managers already checked as project managers', async () => {
+        const projectManager = createMockManager('ms-python.python:venv', 'Venv');
+        const globalManager = createMockManager('ms-python.python:venv', 'Venv');
+
+        const result = await handlePythonPath(testUri, [globalManager], [projectManager]);
+
+        assert.strictEqual(result, undefined);
+        // Project manager checked, but global manager with same id should be skipped
+        assert.strictEqual((projectManager.resolve as sinon.SinonStub).callCount, 1);
+        assert.strictEqual((globalManager.resolve as sinon.SinonStub).callCount, 0);
+    });
+
+    test('returns undefined and does not throw for unresolvable paths', async () => {
+        const manager = createMockManager('ms-python.python:system', 'System');
+
+        const result = await handlePythonPath(Uri.file('/usr/bin/node'), [manager], []);
+
+        assert.strictEqual(result, undefined);
+    });
+
+    test('respects cancellation token', async () => {
+        const cts = new CancellationTokenSource();
+        cts.cancel();
+
+        const manager = createMockManager('ms-python.python:venv', 'Venv');
+
+        const result = await handlePythonPath(testUri, [], [manager], undefined, cts.token);
+
+        assert.strictEqual(result, undefined);
+        assert.strictEqual((manager.resolve as sinon.SinonStub).called, false);
+    });
+
+    test('respects cancellation token for global managers', async () => {
+        const cts = new CancellationTokenSource();
+        cts.cancel();
+
+        const manager = createMockManager('ms-python.python:venv', 'Venv');
+
+        const result = await handlePythonPath(testUri, [manager], [], undefined, cts.token);
+
+        assert.strictEqual(result, undefined);
+        assert.strictEqual((manager.resolve as sinon.SinonStub).called, false);
+    });
+
+    test('reports progress for project managers', async () => {
+        const reporter = { report: sinon.stub() };
+        const projectManager = createMockManager('ms-python.python:venv', 'Venv');
+
+        await handlePythonPath(testUri, [], [projectManager], reporter);
+
+        assert.strictEqual(reporter.report.callCount, 1);
+        assert.deepStrictEqual(reporter.report.firstCall.args[0], { message: 'Checking Venv' });
+    });
+
+    test('reports progress for global managers', async () => {
+        const reporter = { report: sinon.stub() };
+        const manager1 = createMockManager('ms-python.python:venv', 'Venv');
+        const manager2 = createMockManager('ms-python.python:conda', 'Conda');
+
+        await handlePythonPath(testUri, [manager1, manager2], [], reporter);
+
+        assert.strictEqual(reporter.report.callCount, 2);
+        // Conda has higher priority, so it's checked first
+        assert.deepStrictEqual(reporter.report.firstCall.args[0], { message: 'Checking Conda' });
+        assert.deepStrictEqual(reporter.report.secondCall.args[0], { message: 'Checking Venv' });
+    });
+
+    test('sorts managers by priority order', async () => {
+        // Neither resolves, so both get called — lets us verify call order
+        const systemManager = createMockManager('ms-python.python:system', 'System');
+        const condaManager = createMockManager('ms-python.python:conda', 'Conda');
+
+        // Pass system first in array, but conda should be tried first (higher priority)
+        await handlePythonPath(testUri, [systemManager, condaManager], []);
+
+        assert.ok((condaManager.resolve as sinon.SinonStub).calledBefore(systemManager.resolve as sinon.SinonStub));
+    });
+
+    test('returns first resolving manager and stops checking', async () => {
+        const venvEnv = createMockEnv('ms-python.python:venv');
+        const condaEnv = createMockEnv('ms-python.python:conda');
+        const venvManager = createMockManager('ms-python.python:venv', 'Venv', venvEnv);
+        const condaManager = createMockManager('ms-python.python:conda', 'Conda', condaEnv);
+
+        // Conda is higher priority, so it resolves first
+        const result = await handlePythonPath(testUri, [venvManager, condaManager], []);
+
+        assert.strictEqual(result, condaEnv);
+        // Venv should NOT have been called since conda resolved first
+        assert.strictEqual((venvManager.resolve as sinon.SinonStub).called, false);
+    });
+
+    test('returns undefined when both arrays are empty', async () => {
+        const result = await handlePythonPath(testUri, [], []);
+
+        assert.strictEqual(result, undefined);
+    });
+});