Localize all views and messages#70
Merged
karthiknadig merged 3 commits intomicrosoft:mainfrom Dec 10, 2024
karthiknadig:nls2
Merged
Localize all views and messages#70karthiknadig merged 3 commits intomicrosoft:mainfrom karthiknadig:nls2
karthiknadig merged 3 commits intomicrosoft:mainfrom
karthiknadig:nls2
Conversation
cwebster-99
reviewed
Dec 6, 2024
src/common/localize.ts
Outdated
Comment on lines
+76
to
+77
| export const venvErrorNoBasePython = l10n.t('No base python found'); | ||
| export const venvErrorNoPython3 = l10n.t('Did not find any base python 3'); |
Member
There was a problem hiding this comment.
Should these be capital P - Python?
cwebster-99
reviewed
Dec 6, 2024
src/common/localize.ts
Outdated
| } | ||
|
|
||
| export namespace SysManagerStrings { | ||
| export const sysManagerDescription = l10n.t('Manages Global python installs'); |
Member
There was a problem hiding this comment.
Same here- the following lines are capital
cwebster-99
previously approved these changes
Dec 6, 2024
eleanorjboyd
previously approved these changes
Dec 10, 2024
anthonykim1
approved these changes
Dec 10, 2024
NguyenCuong1989
referenced
this pull request
in NguyenCuong1989/vscode-python-environments
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.