feat: add back button to all necessary flows in UI#856
feat: add back button to all necessary flows in UI#856eleanorjboyd merged 4 commits intomicrosoft:mainfrom
Conversation
|
If the changes appear safe, you can manually trigger the pipeline by commenting |
There was a problem hiding this comment.
Pull Request Overview
This PR adds back button functionality to all necessary UI flows within the extension, addressing issues #523 and #855. The changes implement a step-based wizard pattern that allows users to navigate backward through the environment creation process.
- Refactors the Conda environment creation flow to use a step-based wizard pattern with back navigation
- Refactors the venv creation flow to support back navigation through all steps
- Adds back button support to the PET (Python Environment Tool) terminal functionality
- Updates various UI helpers to support back navigation through buttons
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/managers/conda/condaUtils.ts | Exports utility functions and replaces inline flow with step-based Conda flow |
| src/managers/conda/condaStepBasedFlow.ts | New file implementing step-based Conda environment creation with back navigation |
| src/managers/builtin/venvUtils.ts | Replaces inline venv creation logic with step-based flow |
| src/managers/builtin/venvStepBasedFlow.ts | New file implementing step-based venv creation with back navigation |
| src/helpers.ts | Refactors PET terminal functionality to support back navigation |
| src/extension.ts | Updates to use refactored PET terminal functionality |
| src/common/pickers/managers.ts | Adds back button support to manager picker |
Comments suppressed due to low confidence (2)
src/managers/conda/condaStepBasedFlow.ts:1
- This creates infinite recursion. The function calls
createCondaEnvironmentwhich callscreateStepBasedCondaFlow, but this code is already within that flow. The back navigation should return to the step-based flow, not restart the entire process.
import * as fse from 'fs-extra';
src/managers/conda/condaStepBasedFlow.ts:1
- Same infinite recursion issue as above. This should return to the step-based flow rather than calling
createCondaEnvironmentagain.
import * as fse from 'fs-extra';
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
If the changes appear safe, you can manually trigger the pipeline by commenting |
fixes #523 and #855