Fix spacing of general (non-specific) tokens + tests#1222
Fix spacing of general (non-specific) tokens + tests#1222brettcannon merged 15 commits intomicrosoft:masterfrom MikhailArkhipov:master
Conversation
| x+1 # | ||
| @x | ||
| x.y | ||
| if x<=1: |
There was a problem hiding this comment.
This actually won't trigger the bug. It has to have a number on the left-hand side of the operator, e.g. if 1<=x:. Maybe worth keeping this one and just adding another test?
|
|
||
| test('Formatting space after open brace', async () => { | ||
| const text = await formatAtPosition(11, 0); | ||
| assert.equal(text, 'while(1)', 'Method definition with arguments was not formatted'); |
There was a problem hiding this comment.
This isn't a method definition so I think the comment of what failed isn't accurate.
| } | ||
| } | ||
|
|
||
| // In general, keep tokes separated |
There was a problem hiding this comment.
"tokens" and missing a period (couple of other comments are also missing periods).
|
@MikhailArkhipov did you mean to close this? |
Codecov Report
@@ Coverage Diff @@
## master #1222 +/- ##
=========================================
+ Coverage 71.91% 72.11% +0.2%
=========================================
Files 260 260
Lines 11933 11972 +39
Branches 2121 2134 +13
=========================================
+ Hits 8582 8634 +52
+ Misses 3221 3214 -7
+ Partials 130 124 -6
Continue to review full report at Codecov.
|
[skip ci]
2 participants
Fixes #1096
This pull request: