Fix handling of escaped string in tokenizer + PTVS launch hardening#1377
Merged
MikhailArkhipov merged 34 commits intomicrosoft:masterfrom Apr 12, 2018
MikhailArkhipov:master
Merged
Fix handling of escaped string in tokenizer + PTVS launch hardening#1377MikhailArkhipov merged 34 commits intomicrosoft:masterfrom MikhailArkhipov:master
MikhailArkhipov merged 34 commits intomicrosoft:masterfrom
MikhailArkhipov:master
Conversation
DonJayamanne
approved these changes
Apr 12, 2018
| class LanguageServerStartupErrorHandler implements ErrorHandler { | ||
| constructor(private readonly deferred: Deferred<void>) { } | ||
| public error(error: Error, message: Message, count: number): ErrorAction { | ||
| this.deferred.reject(); |
Codecov Report
@@ Coverage Diff @@
## master #1377 +/- ##
==========================================
- Coverage 71.45% 71.14% -0.31%
==========================================
Files 269 269
Lines 12403 12416 +13
Branches 2199 2199
==========================================
- Hits 8862 8833 -29
- Misses 3411 3452 +41
- Partials 130 131 +1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1364
Harden language sever launch
Match PTVS changes in microsoft/PTVS#4024
This pull request: