Conversation
|
Hi @minsa110! Let me know if/when you need a review on this PR. |
|
@brettcannon this is for the getting started experiment: https://github.com/microsoft/devdiv-exp-reviews/issues/112 :) |
|
@kimadeline GitHub didn't update your comment for me until after I posted my previous comment.. Anyways, I was hoping we can get it in by Friday so that this would be in stable for the next release? Thank you for asking! :) |
|
This actually needs to land by Monday afternoon to make the next release. |
|
The |
|
@kimadeline thank you!!! |
luabud
added
the
skip package*.json
|
Just noticed the walkthrough with the link to the data science walkthrough did not have the new tiles that we recently added to the Python walkthrough, so I just added that now. |
|
After talking to @brettcannon I ended up removing the tiles with |
@luabud, could you revert this one? It would show up if a user clicks on "Learn more about getting started with data science" in the pythonWelcomeWithDS tile. |
|
@minsa110 the tiles that I removed were the install Python and open folder ones, and they do not show up if they have the |
|
@luabud yea, I didn't expand below. Looks good, thank you! Will merge now :) |
…hon#18321) * DS walkthrough consolidation experiment * fix python DS walkthrough exp * walkthrough experiment edits * DS walkthrough consolidation experiment Fix merge conflicts * fix python DS walkthrough exp * walkthrough experiment edits * Fix package-lock.json * Address PR comments * Run npm install after fixing typescript version entry * Fix typescript entry on package.json * Regenerate package-lock.json with the hopes it will go away from the PR * restore package-lock.json * Add new line: * Update pythonwithDS walkthrough with new Python walkthrough tiles * Remove tiles with 'when':false Co-authored-by: luabud <luabud@microsoft.com>
4 participants
For microsoft/vscode-jupyter-internal#243