Add dynamic FastAPI debug config#19505
Merged
paulacamargo25 merged 2 commits intomicrosoft:mainfrom Jul 21, 2022
Merged
Conversation
karrtikr
suggested changes
Jul 20, 2022
src/client/debugger/extension/configuration/dynamicdebugConfigurationService.ts
Outdated
Show resolved
Hide resolved
src/client/debugger/extension/configuration/dynamicdebugConfigurationService.ts
Outdated
Show resolved
Hide resolved
src/client/debugger/extension/configuration/dynamicdebugConfigurationService.ts
Outdated
Show resolved
Hide resolved
src/client/debugger/extension/configuration/dynamicdebugConfigurationService.ts
Outdated
Show resolved
Hide resolved
karrtikr
approved these changes
Jul 21, 2022
karrtikr
left a comment
There was a problem hiding this comment.
Thanks for taking care of Django as well, LGTM.
Kludex
reviewed
Aug 4, 2022
| private async getFastApiPath(folder: WorkspaceFolder) { | ||
| const possiblePaths = await this.getPossiblePaths(folder, ['main.py', 'app.py', '*/main.py', '*/app.py']); | ||
| const regExpression = /app\s*=\s*FastAPI\(/; | ||
| const flaskPaths = await asyncFilter(possiblePaths, async (possiblePath) => |
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
* Add dynamic FastAPI debug config * Improve performance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closed: #19452