Create environment using venv or conda

[karthiknadig]

Closes #19676
Closes #19850

[karthiknadig]

@luabud Strings here need your input.

[karrtikr]

Neatly done, most comments are similar related to wording.

Btw, are we not doing the "show log" hyperlink? @luabud

[karrtikr]

Any documentation for this assumption?

[karthiknadig]

This is the same assumption we have in the extension. The docs here describe the "Scripts" or "bin" : https://docs.python.org/3/library/venv.html#creating-virtual-environments

[karrtikr]

Gotcha.

Maybe still add a one line comment linking the doc? I'm asking because it looks like we actually don't use that assumption in discovery and identification:

vscode-python/src/client/pythonEnvironments/common/environmentManagers/simplevirtualenvs.ts

Lines 13 to 31 in e26a1ed

	function getPyvenvConfigPathsFrom(interpreterPath: string): string[] {
	const pyvenvConfigFile = 'pyvenv.cfg';
	// Check if the pyvenv.cfg file is in the parent directory relative to the interpreter.
	// env
	// |__ pyvenv.cfg <--- check if this file exists
	// |__ bin or Scripts
	// |__ python <--- interpreterPath
	const venvPath1 = path.join(path.dirname(path.dirname(interpreterPath)), pyvenvConfigFile);
	// Check if the pyvenv.cfg file is in the directory as the interpreter.
	// env
	// |__ pyvenv.cfg <--- check if this file exists
	// |__ python <--- interpreterPath
	const venvPath2 = path.join(path.dirname(interpreterPath), pyvenvConfigFile);
	// The paths are ordered in the most common to least common
	return [venvPath1, venvPath2];
	}

and this is the first time.

[karthiknadig]

The purpose of the code here and in the discovery is different. In discovery we are tyring to find the .cfg file. in the create env, we created the env, so we know what type it is and where the python.exe will be. I can add the docs nonetheless.

[karrtikr]

Yes, I think the comment is misleading:

// envFolder
// |__ pyvenv.cfg  <--- check if this file exists
// |__ python  <--- interpreterPath

It seems to indicate python binary can be directly under the env folder.

[karrtikr]

Thanks for addressing, LGTM. I still think we could do the hyperlink to log channel #19848 (review) given it so nicely shows the command progress, otherwise looks good.

[karthiknadig]

I still think we could do the hyperlink to log channel

I will definitely add that in an update.