Adding interfaces for datascience work (#1)

[rchiodo]

• Working command with service manager

• Initial interfaces

• Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
• Title summarizes what is changing
• Has a news entry file (remember to thank yourself!)
• Has unit tests & system/integration tests
• Any new/changed dependencies in package.json are pinned (e.g. "1.2.3", not "^1.2.3" for the specified version)
• package-lock.json has been regenerated by running npm install (if dependencies have changed)

[rchiodo]

This is just a skeleton of the work we're starting. I imagine we'll be make a ton more changes like this and then we'll take all of them together into master at a later date.

[brettcannon]

Nothing jumpus out at me, but Don or anyone else on the team may know better. ;)

[IanMatthewHuff]

Note: I've already changed this in my upcoming checkin to instead just inject the service manager and then get the various services that we need off of that.

[DonJayamanne]

Is there a reason why this needs to be awaited.
We need to be careful what happens with the extension activation. At the end of the day, this impacts the time taken for the extension to load, i.e. the time the user has to wait before one can use the extension (intellisense, etc).

Suggestion:

• In the extension activate method (in extensions.ts file), do not await instead do as follows (i.e. invoke activate but do not wait for it to complete: dataScience.activate(context).ignoreErrors()`
• If you need you can add your error logging in the DataScience.activte method as follows:

    @log('Starting Data Science')
    public async activate(context: ExtensionContext): Promise<void> {
        this.registerCommands();
    }

This will add the necessary logging (trace and exceptions).
Please update your branch with latest master to get the log decorator.

[DonJayamanne]

For some reason, the package-lock.json file has been updated unnecessarily. You might want to ensure you have the latest version of npm installed. (version >= 6)

Try installing using npm ci.

We need to ensure package-lock.json doesn't get updated unnecessarily, as the versions of the packages are locked in there and the versions released with the extension are in the 3rd party licenses file (https://github.com/Microsoft/vscode-python/blob/master/ThirdPartyNotices-Distribution.txt).

Suggestion:

• Revert the change to the package-lock.json.
• Will make it easier when merging changes upstream to master branch

[DonJayamanne]

Apologies for the late review.