Automatically activate syntax highlighting using firstLine in package.json to resolve issue 3892#3893
Closed
cgahlon wants to merge 3 commits intomicrosoft:masterfrom
cgahlon:cgahlon/add_firstLine
Closed
Automatically activate syntax highlighting using firstLine in package.json to resolve issue 3892#3893cgahlon wants to merge 3 commits intomicrosoft:masterfrom cgahlon:cgahlon/add_firstLine
cgahlon wants to merge 3 commits intomicrosoft:masterfrom
cgahlon:cgahlon/add_firstLine
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3893 +/- ##
=======================================
- Coverage 81% 79% -2%
=======================================
Files 399 407 +8
Lines 18285 18610 +325
Branches 2951 2996 +45
=======================================
- Hits 14719 14583 -136
- Misses 3563 4024 +461
Partials 3 3
Continue to review full report at Codecov.
|
DonJayamanne
requested changes
Jan 18, 2019
DonJayamanne
left a comment
There was a problem hiding this comment.
@cgahlon
Thanks for the PR, however we only accept PRs that resolve an existing issue.
Please could you file an issue on GitHub the issue you are attempting to resolve.
Author
|
@DonJayamanne - I referenced this pull request in #3892 This is my first PR on github so let me know if there is another step to follow. |
dlech
reviewed
Jan 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #
Unit tests & system/integration tests are added/updatedTest plan is updated as appropriatepackage-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)