Skip to content

Automatically activate syntax highlighting using firstLine in package.json to resolve issue 3892#3893

Closed
cgahlon wants to merge 3 commits intomicrosoft:masterfrom
cgahlon:cgahlon/add_firstLine
Closed

Automatically activate syntax highlighting using firstLine in package.json to resolve issue 3892#3893
cgahlon wants to merge 3 commits intomicrosoft:masterfrom
cgahlon:cgahlon/add_firstLine

Conversation

@cgahlon
Copy link

@cgahlon cgahlon commented Jan 5, 2019

For #

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

@msftclas
Copy link

msftclas commented Jan 5, 2019

CLA assistant check
All CLA requirements met.

@cgahlon cgahlon changed the title Automatically activate syntax highlight using firstLine in package.json Automatically activate syntax highlighting using firstLine in package.json Jan 5, 2019
@codecov
Copy link

codecov bot commented Jan 5, 2019

Codecov Report

Merging #3893 into master will decrease coverage by 3%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #3893    +/-   ##
=======================================
- Coverage      81%     79%    -2%     
=======================================
  Files         399     407     +8     
  Lines       18285   18610   +325     
  Branches     2951    2996    +45     
=======================================
- Hits        14719   14583   -136     
- Misses       3563    4024   +461     
  Partials        3       3
Flag Coverage Δ
#Linux 68% <ø> (+1%) ⬆️
#Windows 68% <ø> (+1%) ⬆️
#macOS 68% <ø> (+1%) ⬆️
Impacted Files Coverage Δ
...r/debugAdapter/DebugServers/RemoteDebugServerv2.ts 22% <0%> (-57%) ⬇️
...er/debugAdapter/DebugServers/LocalDebugServerV2.ts 27% <0%> (-56%) ⬇️
src/client/linters/pydocstyle.ts 39% <0%> (-54%) ⬇️
...debugger/debugAdapter/DebugClients/DebugFactory.ts 47% <0%> (-53%) ⬇️
src/client/datascience/jupyter/jupyterServer.ts 23% <0%> (-49%) ⬇️
...ugger/debugAdapter/DebugServers/BaseDebugServer.ts 24% <0%> (-41%) ⬇️
src/client/datascience/historyProvider.ts 53% <0%> (-39%) ⬇️
src/client/datascience/history.ts 25% <0%> (-36%) ⬇️
src/client/datascience/jupyter/jupyterExporter.ts 49% <0%> (-36%) ⬇️
src/client/datascience/statusProvider.ts 35% <0%> (-33%) ⬇️
... and 137 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c04792...af9d0c1. Read the comment docs.

Copy link

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cgahlon
Thanks for the PR, however we only accept PRs that resolve an existing issue.
Please could you file an issue on GitHub the issue you are attempting to resolve.

@cgahlon cgahlon changed the title Automatically activate syntax highlighting using firstLine in package.json Automatically activate syntax highlighting using firstLine in package.json to resolve issue 3892 Jan 18, 2019
@cgahlon
Copy link
Author

cgahlon commented Jan 18, 2019

@DonJayamanne - I referenced this pull request in #3892

This is my first PR on github so let me know if there is another step to follow.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants