Changes to how source maps are enabled and disabled in the extension#3906
Merged
DonJayamanne merged 2 commits intomicrosoft:masterfrom Jan 18, 2019
Merged
Changes to how source maps are enabled and disabled in the extension#3906DonJayamanne merged 2 commits intomicrosoft:masterfrom
DonJayamanne merged 2 commits intomicrosoft:masterfrom
Conversation
DonJayamanne
force-pushed
the
fixSourceMaps
branch
from
9facf88 to
7842916
Compare
Codecov Report
@@ Coverage Diff @@
## master #3906 +/- ##
=======================================
+ Coverage 78% 79% +1%
=======================================
Files 409 407 -2
Lines 19081 18578 -503
Branches 3042 2987 -55
=======================================
- Hits 14880 14549 -331
+ Misses 4198 4026 -172
Partials 3 3
|
d3r3kk
suggested changes
Jan 17, 2019
d3r3kk
left a comment
d3r3kk
left a comment
There was a problem hiding this comment.
Cool change! Please shift where the tests are being run (or mock out system calls) and this will be g2g.
DonJayamanne
force-pushed
the
fixSourceMaps
branch
from
7842916 to
3b2b343
Compare
Author
|
@d3r3kk Please re-review |
d3r3kk
approved these changes
Jan 18, 2019
|
Thanks for the discussion - we don't need this as we've got other ways of ensuring things stay in sync - I am satisfied. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #3905
[n/a] Test plan is updated as appropriate[n/a]package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)