Skip to content

Match dots in ignorePatterns globs; fixes .venv not being ignored #3948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DonJayamanne merged 1 commit into from
Jan 18, 2019
Merged

Match dots in ignorePatterns globs; fixes .venv not being ignored #3948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions news/2 Fixes/3947.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Match dots in ignorePatterns globs; fixes .venv not being ignored
(thanks to [Russell Davis](https://github.com/russelldavis))
3 changes: 2 additions & 1 deletion src/client/linters/lintingEngine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,8 @@ export class LintingEngine implements ILintingEngine {
const relativeFileName = typeof workspaceRootPath === 'string' ? path.relative(workspaceRootPath, document.fileName) : document.fileName;

const settings = this.configurationService.getSettings(document.uri);
const ignoreMinmatches = settings.linting.ignorePatterns.map(pattern => new Minimatch(pattern));
// { dot: true } is important so dirs like `.venv` will be matched by globs
const ignoreMinmatches = settings.linting.ignorePatterns.map(pattern => new Minimatch(pattern, { dot: true }));
if (ignoreMinmatches.some(matcher => matcher.match(document.fileName) || matcher.match(relativeFileName))) {
return false;
}
Expand Down