Add localRoot & remoteRoot to the launch.json snippets#3950
Merged
d3r3kk merged 3 commits intomicrosoft:masterfrom Jan 22, 2019
Merged
Add localRoot & remoteRoot to the launch.json snippets#3950d3r3kk merged 3 commits intomicrosoft:masterfrom
d3r3kk merged 3 commits intomicrosoft:masterfrom
Conversation
For microsoft#1385 - Will set localRoot to "${workspaceFolder}" by default - Will set remoteRoot to "." by default - PTVSD will (eventually) pick this up and infer "." to be CWD.
Codecov Report
@@ Coverage Diff @@
## master #3950 +/- ##
======================================
Coverage 78% 78%
======================================
Files 402 402
Lines 18572 18572
Branches 2985 2985
======================================
Hits 14352 14352
Misses 4218 4218
Partials 2 2
Continue to review full report at Codecov.
|
DonJayamanne
requested changes
Jan 10, 2019
DonJayamanne
left a comment
DonJayamanne
left a comment
There was a problem hiding this comment.
Tsk tsk tsk, changes to config alone resolved in a big drop of code coverage... 😁
d3r3kk
changed the title
Author
|
@DonJayamanne code coverage + consistency. Now there is a failing functional test in CI though (unrelated). Please have a quick look and let me know if I hit all the beats. |
Author
|
@DonJayamanne ping. |
DonJayamanne
approved these changes
Jan 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #1385
Test plan is updated as appropriatepackage-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)