Expose an event to notify changes to settings instead of casting settings to concrete class#3990
Merged
DonJayamanne merged 25 commits intomicrosoft:masterfrom Jan 17, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3990 +/- ##
======================================
+ Coverage 78% 79% +1%
======================================
Files 410 410
Lines 19079 19083 +4
Branches 3042 3043 +1
======================================
+ Hits 14880 14891 +11
+ Misses 4196 4189 -7
Partials 3 3
|
* master: Fix broken tests (#4008) Give preference to pipen before bash (#4004) Send error information to ERROR event (#4002) Corrected keys in localize.ts (#4000) Ensure LS receives intellicode messages after it starts (#3999) Ensure new warnings are not ignored when bundling with WebPack (#3984) Tweaks to release plan Ensure extension does not start multiple instances of LS at a time (#3974) Dev/ianhu/add remote telemetry (#3986) Revert changes to gulpfile.js (#3996) Fix problem Ian found with the collapse/expand in the codemirror (#3983)
* master: Strong typing of telemetry properties (#4031) Use enums for telemetry event names (#3992) Validate Mac Interpreters in the background (#3909) Ensure configuration changes are debounced correctly (#4037) Allow virtual environments to work with jupyter (#3998) Updates to messages based on review (#4018) Send original event name when sending error event (#4017) Disable debugging configuration provider (#4022) Add more logging for interpreter selection (#3903) Improvements to message displayed when python path is invalid (in launch.json) (#4011) Skip functional tests that aren't successful in Linux on AzDO (#4015) Dev/ianhu/collapse functional tests (#4006)
IanMatthewHuff
requested changes
Jan 17, 2019
Member
IanMatthewHuff
left a comment
IanMatthewHuff
left a comment
There was a problem hiding this comment.
The datascience class disposing doesn't look right here.
rchiodo
reviewed
Jan 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #642
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)