Send "relpath" back for all test files/folders.#6877
Merged
ericsnowcurrently merged 21 commits intomicrosoft:masterfrom Aug 8, 2019
Merged
Send "relpath" back for all test files/folders.#6877ericsnowcurrently merged 21 commits intomicrosoft:masterfrom
ericsnowcurrently merged 21 commits intomicrosoft:masterfrom
Conversation
Author
|
FYI, I know what the problem is in Windows CI and will fix it soon. |
karrtikr
approved these changes
Aug 6, 2019
karrtikr
left a comment
There was a problem hiding this comment.
As far as the key changes go, this looks good to me.
This was referenced Aug 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(for #6758)
The key changes:
There is also a bunch of cleanup (in cases where the code was cluttered enough that I was worried about missing something). (sorry) If that is a problem then let me know and we can walk through the PR.
[ ] Has a news entry file (remember to thank yourself!)[ ] Has sufficient logging.[ ] Has telemetry for enhancements.[ ] Test plan is updated as appropriate[ ]package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)[ ] The wiki is updated with any design decisions/details.