Drop dedent-on-enter for "return" statements.#6939
Merged
ericsnowcurrently merged 21 commits intomicrosoft:masterfrom Aug 13, 2019
Merged
Drop dedent-on-enter for "return" statements.#6939ericsnowcurrently merged 21 commits intomicrosoft:masterfrom
ericsnowcurrently merged 21 commits intomicrosoft:masterfrom
Conversation
ericsnowcurrently
force-pushed
the
drop-return-dedent
branch
from
ad2f095 to
b9a2cf3
Compare
…" (microsoft#6945)" This reverts commit 2402dd5.
ericsnowcurrently
force-pushed
the
drop-return-dedent
branch
from
b9a2cf3 to
ad4a4be
Compare
kimadeline
reviewed
Aug 12, 2019
kimadeline
previously requested changes
Aug 12, 2019
kimadeline
left a comment
kimadeline
left a comment
There was a problem hiding this comment.
Looks good, only got a couple of questions about (╯°□°)╯︵ ┻━┻ sǝxǝƃǝɹ
Author
|
Thanks for the review, @kimadeline. I'd like to talk with you about this PR a bit more, especially since it refactors a bunch of the code that you original wrote. I'll ping you. Also, note that to make this PR work I un-reverted #6497 and then removed the |
DonJayamanne
approved these changes
Aug 13, 2019
ericsnowcurrently
dismissed
kimadeline’s stale review
need to merge this and Don already reviewed (will still check with Kim)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(for #6813)
We'll work on adding support back in #6564.
[ ] Has telemetry for enhancements.[ ] Test plan is updated as appropriate[ ]package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)[ ] The wiki is updated with any design decisions/details.