Since types from `@vscode/test-electron` are reexported, it should be a regular (non-dev) dependency

[bwateratmsft]

A type from @vscode/test-electron is imported here:

vscode-test-cli/src/config.cts

Line 5 in 044359f

import { ProgressReporter } from '@vscode/test-electron';

And then reexported here:

vscode-test-cli/src/config.cts

Line 139 in 044359f

reporter: ProgressReporter;

As a result, @vscode/test-electron should ideally be a regular (non-dev) dependency. Otherwise, type errors result if the consumer doesn't also explicitly install @vscode/test-electron as a dev dependency in package.json.

I can submit a PR to fix this. Or, Copilot could probably handle it easily.

[connor4312]

The CLI does not have a direct runtime dependency on test-electron. It discovers it from wherever it is installed in for the extension

vscode-test-cli/src/cli/platform/desktop.mts

Line 79 in 044359f

private async importTestElectron() {

It's quite intentional that there is no direct dependency

[bwateratmsft]

Would a peer dependency be appropriate then? Or otherwise redeclaring the ProgressReporter type since it is very simple? https://github.com/microsoft/vscode-test/blob/562840ff55ee33969703b228b2de7bb2803b2719/lib/progress.ts#L49-L52

I guess not all that simple since ProgressReport is a big union.

[connor4312]

I think usually it should work in projects because you would also have test-electron installed, and TS should resolve that when looking for ProgressReport

[bwateratmsft]

Yes, though if you have a web-only extension, would you be using @vscode/test-web instead? And due to the type reexport, have to also install @vscode/test-electron just for type checking?