Ensure we use correct workspace folder for remote terminals

[karrtikr]

@Tyriar Last active workspace is not working properly, so getting workspace through cwd instead. Based on #179323 (comment) I was expecting it to be the same as cwd.

Smoke tests are timing out when attempting to use cwd workspace folder in remote terminals, not sure what might be going on. Here's our attempt: 9e4fa31

We can either do this or fix last active workspace so it points to correct workspace folder in multiroot scenarios.

[Tyriar]

Last active workspace is not working properly

Can you elaborate on what's not working exactly? Were the smoke tests failing because last active workspace was undefined? I think it's possible to be in a multi-root window but last active workspace being undefined.

[karrtikr]

There're two problems:

• Last active workspace was not always pointing to the correct workspace folder, for eg. sometimes it would point to workspace1 when it should be workspace2. I was expecting it to be the same as cwd.
• Hence I started using cwd to calculate the active workspace folder instead. But smoke tests fail for some reason when doing that, not sure about the reason.

[Tyriar]

Last active workspace was not always pointing to the correct workspace folder, for eg. sometimes it would point to workspace1 when it should be workspace2. I was expecting it to be the same as cwd.

Any repro on this? Here's what the history service does:

vscode/src/vs/workbench/services/history/browser/historyService.ts

Lines 1073 to 1097 in bcb07d6

	// Multiple folders: find the last active one
	for (const input of this.getHistory()) {
	if (isEditorInput(input)) {
	continue;
	}
	if (schemeFilter && input.resource.scheme !== schemeFilter) {
	continue;
	}
	const resourceWorkspace = this.contextService.getWorkspaceFolder(input.resource);
	if (resourceWorkspace) {
	return resourceWorkspace.uri;
	}
	}
	// Fallback to first workspace matching scheme filter if any
	for (const folder of folders) {
	const resource = folder.uri;
	if (!schemeFilter || resource.scheme === schemeFilter) {
	return resource;
	}
	}
	return undefined;

[karrtikr]

• Open a new terminal using the + icon on top right and select the 2nd workspace folder.
• Put a break point inside getWorkspaceForTerminal function and compare values of cwd and lastActiveWorkspace

I'm not clear on what this.getHistory() is supposed to carry, does it include the 2nd workspace folder when it was selected through +?

[karrtikr]

@Tyriar FYI I can reproduce this in multi root workspace in codespaces, where scoped collections do not seem to work. That can be used to verify the fix.