-
Notifications
You must be signed in to change notification settings - Fork 38.4k
Closed
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bugcandidateIssue identified as probable candidate for fixing in the next releaseIssue identified as probable candidate for fixing in the next releaseterminal-tabsverifiedVerification succeededVerification succeeded
Milestone
Description
This is the reason js-debug isn't working but git is:
vscode/src/vs/platform/terminal/common/environmentVariableCollection.ts
Lines 139 to 161 in 01d4949
| getVariableMap(scope: EnvironmentVariableScope | undefined): Map<string, IExtensionOwnedEnvironmentVariableMutator[]> { | |
| const result = new Map<string, IExtensionOwnedEnvironmentVariableMutator[]>(); | |
| this.map.forEach((mutators, _key) => { | |
| const filteredMutators = mutators.filter(m => filterScope(m, scope)); | |
| if (filteredMutators.length > 0) { | |
| // All of these mutators are for the same variable because they are in the same scope, hence choose anyone to form a key. | |
| result.set(filteredMutators[0].variable, filteredMutators); | |
| } | |
| }); | |
| return result; | |
| } | |
| getDescriptionMap(scope: EnvironmentVariableScope | undefined): Map<string, string | undefined> { | |
| const result = new Map<string, string | undefined>(); | |
| this.descriptionMap.forEach((mutators, _key) => { | |
| const filteredMutators = mutators.filter(m => filterScope(m, scope, true)); | |
| if (filteredMutators.length > 0) { | |
| // There should be exactly one description per extension per scope. | |
| result.set(filteredMutators[0].extensionIdentifier, filteredMutators[0].description); | |
| } | |
| }); | |
| return result; | |
| } |
This is probably a good candidate for recovery, not a good reason to push 1.80.0 out though.
Reactions are currently unavailable
Metadata
Metadata
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bugcandidateIssue identified as probable candidate for fixing in the next releaseIssue identified as probable candidate for fixing in the next releaseterminal-tabsverifiedVerification succeededVerification succeeded