Cannot select a path outside the workspace to save the file

[yiliang114]

ADD ISSUE DESCRIPTION HERE

Version: 1.81.1
Commit: 6c3e3db
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/115.0.0.0 Safari/537.36
Embedder: vscode.dev

Steps:

1. Open a repo on vscode.dev
2. Open a file in any directory
3. Double-click the blank space to create a new file and use the shortcut key to save it
4. You can find the path to save the file can directly click on the previous level

Although the path beyond the current workspace is not saved successfully, in theory, it should not be possible to choose such a path.

[yiliang114]

The code to determine whether you can continue to select the upper directory is here：

vscode/src/vs/workbench/services/dialogs/browser/simpleFileDialog.ts

Line 956 in 9e927a6

const fileRepresentationParent = resources.dirname(fileRepresentationCurr);

The reason for the problem is that the Uri value of the file opened by the workspace is as follows: it will carry the root directory of the workspace.

The actual path of resources.dirname(fileRepresentationCurr) in the previous comparison method represents file://.
Therefore, even if you are currently in the root directory, you can continue to select the next level.

[yiliang114]

@alexr00 Is it possible to add an attribute to ISaveDialogOptions to indicate that paths outside the workspace cannot be selected?

[alexr00]

We now show an error in the simple file picker if you try to safe in a place that doesn't support it with Remote Repositories.