Label name with undefined when the workspace is not named (fix #171402)#171412
Merged
Label name with undefined when the workspace is not named (fix #171402)#171412
undefined when the workspace is not named (fix #171402)#171412Conversation
lszomoru
approved these changes
Jan 16, 2023
Collaborator
|
I think this makes sense. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@isidorn @aeschli fyi, an extension is not enforced to provide the
separatoroption and the vscode test web extension does not:https://github.com/microsoft/vscode-test-web/blob/main/fs-provider/package.json#L23
I think we cannot trust the values from the extension and thus need to fill in defaults for the required types we have.