Skip to content

Show sparkle lightbulb on the end of a line containing only whitespace characters#199518

Closed
aiday-mar wants to merge 11 commits intomainfrom
aiday/fixingNoUpdateOnSettingChange
Closed

Show sparkle lightbulb on the end of a line containing only whitespace characters#199518
aiday-mar wants to merge 11 commits intomainfrom
aiday/fixingNoUpdateOnSettingChange

Conversation

@aiday-mar
Copy link
Copy Markdown
Contributor

@aiday-mar aiday-mar commented Nov 29, 2023

⚠️ merge after #199786 is merged

Fixes #199458

@aiday-mar aiday-mar self-assigned this Nov 29, 2023
@aiday-mar aiday-mar requested a review from aeschli November 29, 2023 10:22
@aiday-mar aiday-mar marked this pull request as ready for review November 29, 2023 10:22
@aiday-mar aiday-mar changed the title Doing the empty line check in relation to the showAiIcon setting inside of the method _updateLightBulbTitleAndIcon Show sparkle lightbulb on the end of a line containing only whitespace characters Dec 4, 2023
@aiday-mar
Copy link
Copy Markdown
Contributor Author

I changed the code so that on the VS Code side, when showAIIcon is enabled, we show the sparkle icon at the end of a line containing only whitespace characters too.

This PR also fixes an issue with the current code. More specifically in:

if (onlyAIActions && !showAiIcon) {
 return this.hide();
}

There was a ! missing in front of showAiIcon.

This PR requires #199786 to be merged.

@aiday-mar aiday-mar requested a review from aeschli December 4, 2023 13:02
@aiday-mar aiday-mar closed this Dec 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Depending on the setting a different icon is shown

2 participants