Skip to content

Conversation

@CharlesHGong
Copy link

@CharlesHGong CharlesHGong commented May 19, 2024

Fixes #213034

This caller is missing to pass in the timeout variable.
Otherwise it won't respect the maxComputationTimeMs option that was passed in in computeDiff

The definition of the myersDiffingAlgorithm.compute looks like this

compute(seq1: ISequence, seq2: ISequence, timeout: ITimeout = InfiniteTimeout.instance)

@CharlesHGong
Copy link
Author

cc @hediet the last editor of the line.

Copy link
Member

@hediet hediet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hediet hediet enabled auto-merge (squash) May 27, 2024 16:37
@hediet hediet added this to the May 2024 milestone May 27, 2024
@hediet hediet merged commit dccb86c into microsoft:main May 27, 2024
@microsoft microsoft locked and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DefaultLinesDiffComputer did not pass timeout as an option

5 participants