allow returning undefined if file was not saved #213123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalebers
approved these changes
May 21, 2024
bpasero
requested changes
May 21, 2024
src/vs/workbench/services/workingCopy/common/storedFileWorkingCopy.ts
Outdated
Show resolved
Hide resolved
bpasero
requested changes
May 22, 2024
Member
bpasero
left a comment
bpasero
left a comment
There was a problem hiding this comment.
Looks better, are we able to write a test for this?
bpasero
requested changes
May 22, 2024
src/vs/workbench/services/workingCopy/common/storedFileWorkingCopy.ts
Outdated
Show resolved
Hide resolved
bpasero
approved these changes
May 23, 2024
rebornix
approved these changes
May 23, 2024
andremmsilva
pushed a commit
to PIC1G55/vscodeG55
that referenced
this pull request
May 26, 2024
* allow returning undefined if file was not saved * bring back cancellation check * helper utility to convey optional result if cancelled * edit * inline function * test cancelled custom save * inline more --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to allow cancellation from the delegated save action without showing the user an error.
microsoft/vscode-jupyter#15698