Skip to content

Conversation

@amunger
Copy link
Collaborator

@amunger amunger commented May 21, 2024

Added some trace logs to help troubleshoot saving issues and also more detail in the error telemetry to know more about the error type frequency.

microsoft/vscode-jupyter#15698

@vscodenpa vscodenpa added this to the May 2024 milestone May 21, 2024
lramos15
lramos15 previously approved these changes May 21, 2024
@amunger amunger enabled auto-merge (squash) May 21, 2024 20:13
@amunger amunger merged commit 5328a3f into main May 21, 2024
@amunger amunger deleted the aamunger/saveDiagnostics branch May 21, 2024 22:23
throw new Error(`scheme '${scheme}' already registered`);
}

this._logService.warn('TEST WARNING');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be removed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, yes

mustard-mh pushed a commit to gitpod-io/openvscode-server that referenced this pull request May 22, 2024
* added trace logs

* another trace message

* fix test ctors
andremmsilva pushed a commit to PIC1G55/vscodeG55 that referenced this pull request May 26, 2024
* added trace logs

* another trace message

* fix test ctors
@microsoft microsoft locked and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants