Scope custom editor and webview context keys to editor groups and global context #213398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbvz
approved these changes
May 24, 2024
andremmsilva
pushed a commit
to PIC1G55/vscodeG55
that referenced
this pull request
May 26, 2024
…bal context (microsoft#213398) Properly scope custom editor and webview context keys
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure the webview and custom editor context keys are also set for each editor group by using the
registerContextKeyProviderwhich was recently introduced. This makes sure editor actions are rendered in the correct editor group when usingworkbench.editor.alwaysShowEditorActions: true// cc @mjbvz
Ref: #209962