Skip to content

ts - enable use code watcher by default #213450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bpasero merged 1 commit into from
May 25, 2024
Merged

ts - enable use code watcher by default #213450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,5 @@
},
"css.format.spaceAroundSelectorSeparator": true,
"inlineChat.mode": "live",
"typescript.enablePromptUseWorkspaceTsdk": true,
"typescript.tsserver.experimental.useVsCodeWatcher": true
"typescript.enablePromptUseWorkspaceTsdk": true
}
5 changes: 1 addition & 4 deletions extensions/typescript-language-features/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1177,10 +1177,7 @@
"typescript.tsserver.experimental.useVsCodeWatcher": {
"type": "boolean",
"description": "%configuration.tsserver.useVsCodeWatcher%",
"default": false,
"tags": [
"experimental"
]
"default": true
},
"typescript.tsserver.watchOptions": {
"type": "object",
Expand Down
2 changes: 1 addition & 1 deletion extensions/typescript-language-features/src/configuration/configuration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ export interface TypeScriptServiceConfiguration {
readonly enableProjectDiagnostics: boolean;
readonly maxTsServerMemory: number;
readonly enablePromptUseWorkspaceTsdk: boolean;
readonly useVsCodeWatcher: boolean;
readonly useVsCodeWatcher: boolean; // TODO@bpasero remove this setting eventually
readonly watchOptions: Proto.WatchOptions | undefined;
readonly includePackageJsonAutoImports: 'auto' | 'on' | 'off' | undefined;
readonly enableTsServerTracing: boolean;
Expand Down
3 changes: 2 additions & 1 deletion src/vs/workbench/contrib/files/browser/workspaceWatcher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,8 @@ export class WorkspaceWatcher extends Disposable {
reason = 'ETERM';
}

// Log telemetry if we gathered a reason (TODO@bpasero remove me once the TS experiment is over)
// Log telemetry if we gathered a reason (logging it from the renderer
// allows us to investigate this situation in context of experiments)
if (reason) {
type WatchErrorClassification = {
owner: 'bpasero';
Expand Down