debt: finish adopting ensureNoDisposablesAreLeakedInTestSuite #249678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #200091 Notably makes `raceCancellablePromises` itself be cancellable to allow for composition, and make `Event.toPromise` cancellable too.
Member
Author
|
Also closes #204205 fyi @TylerLeonhardt , this ended up not being much work |
TylerLeonhardt
approved these changes
May 24, 2025
Member
TylerLeonhardt
left a comment
TylerLeonhardt
left a comment
There was a problem hiding this comment.
approving in quick access
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #200091
Notably makes
raceCancellablePromisesitself be cancellable to allowfor composition, and make
Event.toPromisecancellable too.