Fix element already registered #281000
Merged
Fix element already registered #281000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue microsoft/vscode-pull-request-github#8073 where concurrent tree view operations could throw an "Element with id X is already registered" error. The fix handles the case where the same element (same object reference) is being registered multiple times concurrently by updating the existing node instead of throwing an error.
Key changes:
- Modified
_createAndRegisterTreeNodeto detect when an element with the same ID is being re-registered - If the element is the same object, update the existing node instead of throwing an error
- If the element is a different object with the same ID, still throw the error (correct behavior)
- Added comprehensive test for concurrent
revealoperations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/vs/workbench/api/common/extHostTreeViews.ts |
Modified _createAndRegisterTreeNode method to handle concurrent registration of the same element by updating the existing node instead of throwing an error |
extensions/vscode-api-tests/src/singlefolder-tests/tree.test.ts |
Added new test suite with a test case that verifies concurrent reveal operations on the same element don't throw the "already registered" error |
roblourens
approved these changes
Dec 3, 2025
alexr00
added a commit
that referenced
this pull request
Dec 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/vscode-pull-request-github#8073