Skip to content

Add npm-shrinkwrap and package-lock files from npm 5.0.3 (node 8.1.2)#29137

Closed
roblourens wants to merge 1 commit intomasterfrom
npm5packageChanges
Closed

Add npm-shrinkwrap and package-lock files from npm 5.0.3 (node 8.1.2)#29137
roblourens wants to merge 1 commit intomasterfrom
npm5packageChanges

Conversation

@roblourens
Copy link
Member

No description provided.

@Tyriar
Copy link
Member

Tyriar commented Jun 20, 2017

Adding @joaomoreno as he was the gatekeeper for this sort of stuff in the past I believe.

@roblourens
Copy link
Member Author

@joaomoreno joaomoreno added this to the June 2017 milestone Jun 21, 2017
@felixfbecker
Copy link
Contributor

felixfbecker commented Jun 21, 2017

package-lock.json is the new npm-shrinkwrap.json (the only difference is that npm-shrinkwrap.json will get published to npm). You can upgrade by simply running npm install (which will migrate the shrinkwrap files), then renaming all npm-shrinkwrap.json to package-lock.json (they have the same schema). But they are not backward-compatible, so Travis would need to npm i -g npm@5 in before_install.

@joaomoreno
Copy link
Member

joaomoreno commented Jun 22, 2017

I will definitely not have time for this in June. If someone wants to pick it up and make sure all our builds (TFS, Travis, AppVeyour) would still work with this, be my guest.

@joaomoreno joaomoreno modified the milestones: Backlog, June 2017 Jun 22, 2017
@felixfbecker
Copy link
Contributor

felixfbecker commented Jun 27, 2017

@joaomoreno did it #29576

@joaomoreno joaomoreno added the engineering VS Code - Build / issue tracking / etc. label Jun 27, 2017
@roblourens roblourens closed this Jul 3, 2017
@roblourens roblourens deleted the npm5packageChanges branch July 3, 2017 16:30
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

engineering VS Code - Build / issue tracking / etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants