Setting for visual overlay on terminal resize #311843
Draft
anthonykim1 wants to merge 3 commits intomainfrom
Draft
Setting for visual overlay on terminal resize #311843anthonykim1 wants to merge 3 commits intomainfrom
anthonykim1 wants to merge 3 commits intomainfrom
Conversation
Contributor
Screenshot ChangesBase: Changed (1)
|
| Before | After |
|---|---|
 |
 |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a user setting to control whether the terminal resize dimensions overlay (cols x rows) is shown, addressing the request in #295790.
Changes:
- Introduces
terminal.integrated.resizeDimensionsOverlay.enabled(default:true) to allow disabling the overlay. - Wires the overlay contribution to create/dispose the overlay based on the setting and react to setting changes.
- Exports the new configuration schema via the central terminal contrib configuration aggregator.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/contrib/terminalContrib/resizeDimensionsOverlay/common/terminalResizeDimensionsOverlayConfiguration.ts |
Defines the new boolean setting schema and its localized description. |
src/vs/workbench/contrib/terminalContrib/resizeDimensionsOverlay/browser/terminal.resizeDimensionsOverlay.contribution.ts |
Observes configuration changes and conditionally enables/disables the resize overlay. |
src/vs/workbench/contrib/terminal/terminalContribExports.ts |
Registers the new configuration schema in the terminal contrib configuration set. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 0
Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #295790