Changes to include workspaceStorage directory for allowRead#313820
Open
dileepyavan wants to merge 1 commit intomainfrom
Open
Changes to include workspaceStorage directory for allowRead#313820dileepyavan wants to merge 1 commit intomainfrom
dileepyavan wants to merge 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses #313022 by ensuring the terminal sandbox configuration explicitly re-allows read access to the current workspace’s workspaceStorage directory, even when the user home directory is broadly denied for reads. This helps keep workspace-scoped temporary/state files (e.g. content.json) accessible within the sandboxed execution model.
Changes:
- Extend sandbox config generation to include the workspace’s storage directory in
filesystem.allowRead. - Add a browser test validating that workspace storage under the user home is denied generally but re-allowed for the active workspace.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/common/terminalSandboxService.ts | Adds workspaceStorageHome/<workspaceId> into generated allowRead paths. |
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/browser/terminalSandboxService.test.ts | Adds coverage to ensure workspace storage is re-allowed even when home is denied. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
roblourens
approved these changes
May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #313022