Skip to content

Conversation

@IllusionMH
Copy link
Contributor

PR microsoft/TypeScript#32064 brings several improvements to how template literals are treated.

Currently I'm working on improving handling of template literals in various TS services and will update this PR if any changes needed to support updated functionality.

Current list of changes:

  1. Trigger completions when user types ` in the same way as when they type ' or " (as per suggestion in Better template literals support in checker TypeScript#32064 (comment))

@IllusionMH IllusionMH force-pushed the better-tempate-literal-support branch from eb42f0f to a458b7d Compare November 4, 2019 18:42
@IllusionMH IllusionMH marked this pull request as ready for review November 4, 2019 18:42
@IllusionMH
Copy link
Contributor Author

IllusionMH commented Nov 4, 2019

Ooops, forgot about this one. 🤦‍♂

PR microsoft/TypeScript#32064 is merged and after investigation across other services there is nothing that needs updates on VS Code side.

It was planned for VS Code version shipped with 3.7 but I understand that missed feature freeze. so can be added with #83935.

@mjbvz mjbvz added this to the November 2019 milestone Nov 4, 2019
@mjbvz mjbvz merged commit a188b90 into microsoft:master Nov 4, 2019
@mjbvz
Copy link
Collaborator

mjbvz commented Nov 4, 2019

Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants