Exclude .signature.p7s from nupkg file count#10418
Merged
nohwnd merged 1 commit intomicrosoft:mainfrom Nov 7, 2024
Merged
Conversation
Contributor
Author
|
@nohwnd - can I please get your review on this? Pinging because I'm unable to add you as a reviewer to the PR. Thanks in advance! |
nohwnd
approved these changes
Nov 7, 2024
Member
|
Looks great. Feel free to ping also next time, it is more effective :) |
1 task
This was referenced Jul 21, 2025
Merged
This was referenced Apr 1, 2026
Open
Open
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10414
This PR adds logic to exclude
.signature.p7sfiles from the file count when verifying nupkgs inverify-nupkgs.ps1. This allows the verification to still pass when the artifacts are signed.