Break infinite restore loop in VS#15503
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Implements a workaround for dotnet/arcade#16228 by preventing Visual Studio from entering an infinite NuGet restore loop caused by a property name collision for the Microsoft.VSSDK.BuildTools version.
Changes:
- Renames the
Microsoft.VSSDK.BuildToolsversion MSBuild property to a collision-resistant name (_MicrosoftVSSDKBuildToolsVersion_). - Updates
Microsoft.TestPlatform.csprojto consume the new property name. - Adds a repo-wide
PackageReference Updateto pin/overrideMicrosoft.VSSDK.BuildToolsto the intended version.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/package/Microsoft.TestPlatform/Microsoft.TestPlatform.csproj | Switches the Microsoft.VSSDK.BuildTools version to the new underscore-delimited property. |
| eng/Versions.props | Introduces _MicrosoftVSSDKBuildToolsVersion_ and documents the restore-loop workaround. |
| Directory.Build.targets | Adds a repo-wide PackageReference Update to ensure the pinned build tools version is applied. |
Member
Author
|
force merged, only applies to VS (most often) and it built on server as well |
This was referenced Mar 25, 2026
This was referenced May 26, 2026
Merged
Closed
Merged
This was referenced May 29, 2026
Open
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Workaround for dotnet/arcade#16228