Enable parallelization for blame data collector tests#15552
Merged
Conversation
Move [DoNotParallelize] from class level to only the BlameDataCollectorAeDebuggerShouldCollectDump test method, which is the only test that modifies machine-wide state (HKLM registry via procdump AeDebugger install/uninstall). The other 10 blame tests use fully isolated state: - Unique TempDirectory per test (RandomId) - Separate vstest.console and testhost processes - Per-process procdump attachment with unique file names - Named events scoped by process ID Fixes microsoft#15530 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR narrows test non-parallelization scope for blame data collector integration tests by moving [DoNotParallelize] from the entire BlameDataCollectorTests class to only the one test that mutates machine-wide AeDebug registry state.
Changes:
- Removed class-level
[DoNotParallelize]fromBlameDataCollectorTests - Added method-level
[DoNotParallelize]toBlameDataCollectorAeDebuggerShouldCollectDump - Updated comments to document the rationale for the remaining non-parallelized test
nohwnd
added
the
🚢 Ship it!
Evangelink
approved these changes
Mar 24, 2026
This was referenced Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move
[DoNotParallelize]from class level to only theBlameDataCollectorAeDebuggerShouldCollectDumptest method.Investigation (Fixes #15530)
PR #15526 added
[DoNotParallelize]to the entireBlameDataCollectorTestsclass with the comment "Blame tests collect crash/hang dumps from child processes and race when run in parallel." This is overly broad.Why most blame tests CAN parallelize
Each blame test method:
RandomId.Next())/Blameoptions{processName}_{processId}_{timestamp})ProcDump-{targetProcessId})PROCDUMP_PATHis passed as a per-process environment variableBlameCollectoruses only instance fields — no static mutable stateThere is no shared state between parallel runs of these tests.
Why one test CANNOT parallelize
BlameDataCollectorAeDebuggerShouldCollectDumpmodifies machine-wide registry state by installing/uninstalling procdump as the Windows postmortem debugger (HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\AeDebug). Multiple parallel executions would race on this global registry key.Change
[DoNotParallelize][DoNotParallelize]only toBlameDataCollectorAeDebuggerShouldCollectDump